Avoid creating ConstantComposites with spec constants#3662
Open
svenvh wants to merge 1 commit intoKhronosGroup:mainfrom
Open
Avoid creating ConstantComposites with spec constants#3662svenvh wants to merge 1 commit intoKhronosGroup:mainfrom
svenvh wants to merge 1 commit intoKhronosGroup:mainfrom
Conversation
A recent version of spirv-val is now reporting "OpConstantComposite must not have spec constant operands" for some tests. Fix by letting `addCompositeConstant` defer to `addSpecConstantComposite` when attempting to add a constant that has one or more specialization constant operands.
svenvh
force-pushed
the
ConstantComposites-spec
branch
from
ed2b659 to
8e4b379
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A recent version of spirv-val is now reporting "OpConstantComposite must not have spec constant operands" for some tests.
Fix by letting
addCompositeConstantdefer toaddSpecConstantCompositewhen attempting to add a constant that has one or more specialization constant operands.